<html>
<head><meta charset="utf-8"><title>New bug labels · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html">New bug labels</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220357983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220357983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220357983">(Dec 18 2020 at 10:50)</a>:</h4>
<p>fyi: I went ahead and created two new labels to better categorize our bugs: <a href="https://github.com/rust-lang/rust-clippy/labels/L-false-positive">L-false-positive</a> and <a href="https://github.com/rust-lang/rust-clippy/labels/L-false-negative">L-false-negative</a>. Currently going through the open bugs and adding them where neccessary</p>



<a name="220366023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220366023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220366023">(Dec 18 2020 at 12:29)</a>:</h4>
<p><span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> It would be great, if you could also use those labels when labeling issues &lt;3</p>



<a name="220398461"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220398461" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220398461">(Dec 18 2020 at 16:59)</a>:</h4>
<p>What's the difference between a false negative and an enhancement?</p>



<a name="220399327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220399327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220399327">(Dec 18 2020 at 17:04)</a>:</h4>
<p>'false negative' is "this should have been caught by the lint but wasn't"</p>



<a name="220399369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220399369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220399369">(Dec 18 2020 at 17:05)</a>:</h4>
<p>'enhancement' is "the lint could be improved in some way" (probably diagnostics if I had to guess)</p>



<a name="220399420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220399420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220399420">(Dec 18 2020 at 17:05)</a>:</h4>
<p>(and 'false positive' is "this should not have warned but did")</p>



<a name="220399736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220399736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220399736">(Dec 18 2020 at 17:07)</a>:</h4>
<p>For example, I wouldn't know whether to call this a false negative or an enhancement.<br>
<a href="https://github.com/rust-lang/rust-clippy/issues/6423">https://github.com/rust-lang/rust-clippy/issues/6423</a></p>



<a name="220399850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220399850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220399850">(Dec 18 2020 at 17:08)</a>:</h4>
<p>Most enhancements amount to "this lint can catch another case"</p>



<a name="220399901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220399901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220399901">(Dec 18 2020 at 17:08)</a>:</h4>
<p>ah hmm ok, I'm not sure then</p>



<a name="220400144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220400144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Stu <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220400144">(Dec 18 2020 at 17:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="360405">Cameron Steffen</span> <a href="#narrow/stream/257328-clippy/topic/New.20bug.20labels/near/220399736">said</a>:</p>
<blockquote>
<p>For example, I wouldn't know whether to call this a false negative or an enhancement.<br>
<a href="https://github.com/rust-lang/rust-clippy/issues/6423">https://github.com/rust-lang/rust-clippy/issues/6423</a></p>
</blockquote>
<p>IMO this should be both</p>



<a name="220402440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220402440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220402440">(Dec 18 2020 at 17:26)</a>:</h4>
<p>I also noticed that issues are sometimes tagged as a bug <em>and</em> an enhancement. IMO a false negative is an enhancement and a false positive is a bug.</p>



<a name="220425478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220425478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220425478">(Dec 18 2020 at 20:39)</a>:</h4>
<p><span class="user-mention" data-user-id="360405">@Cameron Steffen</span> if they're both, you can label them as both. </p>
<p>The most helpful labels are the difficulty labels of issues anyway. At least for contributors.</p>



<a name="220426029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/New%20bug%20labels/near/220426029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Cameron Steffen <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/New.20bug.20labels.html#220426029">(Dec 18 2020 at 20:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="264664">flip1995</span> <a href="#narrow/stream/257328-clippy/topic/New.20bug.20labels/near/220425478">said</a>:</p>
<blockquote>
<p>if they're both, you can label them as both.</p>
</blockquote>
<p>Makes sense. I assume you're referring to false negative and enhancement.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>